Remove block assets enqueuing from editor document #54250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/client-assets.php |
|
Size Change: +93 kB (+6%) 🔍 Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f50d91f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6186862966
|
ellatrix
force-pushed
the
try/editor-dequeue-block-assets
branch
from
3065028
to
f50d91f
Compare
ellatrix
changed the title
mikachan
added
the
Backport to WP 6.7 Beta/RC
|
@ellatrix is this still slated for 6.4? I'm not seeing moving in over a month and, at this point with RC1 out, we have to narrow what we are comfortable merging. |
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
It's not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes enqueuing of block assets (meant for editor content) from the main editor document. For the iframed editor, these assets are already loaded inside the iframe, so they are not needed and currently loaded twice. For the non iframed editor, they should still be loaded in the main editor document, so we can render them only when needed.
Why?
For the iframed editor (most cases), the assets are loaded twice.
Fixes #53590.
How?
Testing Instructions
Load the editor. Everything should look as expected.
Run the following script:
The iframe will be removed, but everything should look the same.
Testing Instructions for Keyboard
Screenshots or screencast